-
Notifications
You must be signed in to change notification settings - Fork 10
[O11y] Adds channel data to inference and tool scopes. #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O11y] Adds channel data to inference and tool scopes. #89
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds channel data (source metadata) to inference and tool execution observability scopes. The changes enable tracking of execution source information (channel name and link/description) through OpenTelemetry span attributes, providing better context for agent operations.
Key Changes:
- Extended
InferenceScopeandExecuteToolScopeto capture and record source metadata from requests - Updated copyright headers in test files to follow the standard Microsoft format
- Added comprehensive tests to verify source metadata is correctly set on spans
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/observability/core/test_inference_scope.py | Updated copyright header and added test for source metadata on inference spans |
| tests/observability/core/test_execute_tool_scope.py | Added test for source metadata on tool execution spans |
| libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/inference_scope.py | Added source metadata capture logic to set channel attributes on spans |
| libraries/microsoft-agents-a365-observability-core/microsoft_agents_a365/observability/core/execute_tool_scope.py | Added source metadata capture logic and request parameter support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
|
Any reason conversation Id is not included in this PR? |
Also fixes assertions that were never running to validate data within the generated span.